On 03/31, Jonathan Nieder wrote:
> Brandon Williams wrote:
>
> > Also, clear the push_options string_list to
> > prevent memory leaking.
>
> That's not a real leak, right? Is the motivation to make it not show up
> in valgrind output?
well depends on what you classify as
Brandon Williams wrote:
> Also, clear the push_options string_list to
> prevent memory leaking.
That's not a real leak, right? Is the motivation to make it not show up
in valgrind output?
At first it didn't look related to the other change but then the
connection dawned
There isn't any obvious reason for the 'struct string_list push_options'
and 'struct string_list_item *item' to be marked as static, so unmark
them as being static. Also, clear the push_options string_list to
prevent memory leaking.
Signed-off-by: Brandon Williams
---
builtin/push.c | 5 +++--
3 matches
Mail list logo