Re: [PATCH v2 1/2] t1300: extract and use test_cmp_config()

2018-09-30 Thread SZEDER Gábor
On Sat, Sep 29, 2018 at 05:30:04PM +0200, Nguyễn Thái Ngọc Duy wrote: > In many config-related tests it's common to check if a config variable > has expected value and we want to print the differences when the test > fails. Doing it the normal way is three lines of shell code. Let's add > a functio

Re: [PATCH v2 1/2] t1300: extract and use test_cmp_config()

2018-09-29 Thread Eric Sunshine
On Sat, Sep 29, 2018 at 11:30 AM Nguyễn Thái Ngọc Duy wrote: > In many config-related tests it's common to check if a config variable > has expected value and we want to print the differences when the test > fails. Doing it the normal way is three lines of shell code. Let's add > a function do to

[PATCH v2 1/2] t1300: extract and use test_cmp_config()

2018-09-29 Thread Nguyễn Thái Ngọc Duy
In many config-related tests it's common to check if a config variable has expected value and we want to print the differences when the test fails. Doing it the normal way is three lines of shell code. Let's add a function do to all this (and a little more). This function has uses outside t1300 as