Re: [PATCH v2 1/2] xdiff: reassign xpparm_t.flags bits

2017-11-07 Thread Junio C Hamano
Johannes Schindelin writes: >> diff --git a/xdiff/xdiff.h b/xdiff/xdiff.h >> index b090ad8eac..cbf5d8e166 100644 >> --- a/xdiff/xdiff.h >> +++ b/xdiff/xdiff.h >> @@ -27,22 +27,26 @@ >> extern "C" { >> #endif /* #ifdef __cplusplus */ >> >> +/* xpparm_t.flags */ >>

Re: [PATCH v2 1/2] xdiff: reassign xpparm_t.flags bits

2017-11-07 Thread Johannes Schindelin
Hi Junio, On Tue, 7 Nov 2017, Junio C Hamano wrote: > We have packed the bits too tightly in such a way that it is not > easy to add a new type of whitespace ignoring option, a new type > of LCS algorithm, or a new type of post-cleanup heuristics. > > Reorder bits a bit to give room for these

[PATCH v2 1/2] xdiff: reassign xpparm_t.flags bits

2017-11-06 Thread Junio C Hamano
We have packed the bits too tightly in such a way that it is not easy to add a new type of whitespace ignoring option, a new type of LCS algorithm, or a new type of post-cleanup heuristics. Reorder bits a bit to give room for these three classes of options to grow. Also make use of