Re: [PATCH v2 1/3] send-email: add and use a local copy of Mail::Address

2018-02-14 Thread Ævar Arnfjörð Bjarmason
On Fri, Jan 5, 2018 at 7:36 PM, Matthieu Moy wrote: > create mode 100644 perl/Git/FromCPAN/Mail/Address.pm > create mode 100755 perl/Git/Mail/Address.pm I didn't notice this in my initial review, but just now when it's landed in master and it's shiny-green in my

[PATCH v2 1/3] send-email: add and use a local copy of Mail::Address

2018-01-05 Thread Matthieu Moy
We used to have two versions of the email parsing code. Our parse_mailboxes (in Git.pm), and Mail::Address which we used if installed. Unfortunately, both versions have different sets of bugs, and changing the behavior of git depending on whether Mail::Address is installed was a bad idea. A first