Re: [PATCH v2 1/5] trailer: be stricter in parsing separators

2016-11-01 Thread Junio C Hamano
Jonathan Tan writes: >>> Hmph. The optional whitespace is to allow for what kind of line? >>> >>> It is not for "Signed off by:" that is a misspelt "Signed-off-by:"; >>> it may not hurt but I do not think of a case that would be useful >>> offhand. > > This is to allow

Re: [PATCH v2 1/5] trailer: be stricter in parsing separators

2016-11-01 Thread Jonathan Tan
On 11/01/2016 01:37 PM, Junio C Hamano wrote: Junio C Hamano writes: Jonathan Tan writes: Currently, a line is interpreted to be a trailer line if it contains a separator. Make parsing stricter by requiring the text on the left of the separator,

Re: [PATCH v2 1/5] trailer: be stricter in parsing separators

2016-11-01 Thread Junio C Hamano
Junio C Hamano writes: > Jonathan Tan writes: > >> Currently, a line is interpreted to be a trailer line if it contains a >> separator. Make parsing stricter by requiring the text on the left of >> the separator, if not the empty string, to be of the

Re: [PATCH v2 1/5] trailer: be stricter in parsing separators

2016-11-01 Thread Junio C Hamano
Jonathan Tan writes: > Currently, a line is interpreted to be a trailer line if it contains a > separator. Make parsing stricter by requiring the text on the left of > the separator, if not the empty string, to be of the " whitespace>" form. Hmph. The optional

[PATCH v2 1/5] trailer: be stricter in parsing separators

2016-11-01 Thread Jonathan Tan
Currently, a line is interpreted to be a trailer line if it contains a separator. Make parsing stricter by requiring the text on the left of the separator, if not the empty string, to be of the "" form. (The find_separator function distinguishes the no-separator case from the