Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook

2017-04-13 Thread Eric Wong
Brandon Williams wrote: > On 04/13, Eric Wong wrote: > > Jonathan Nieder wrote: > > > Brandon Williams wrote: > > > > The post-update hooks created in t5550-http-fetch-dumb.sh is missing the > > > > "!#/bin/sh" line which can cause issues with portability.

Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook

2017-04-13 Thread Brandon Williams
On 04/13, Eric Wong wrote: > Jonathan Nieder wrote: > > Brandon Williams wrote: > > > The post-update hooks created in t5550-http-fetch-dumb.sh is missing the > > > "!#/bin/sh" line which can cause issues with portability. Instead > > > create the hook using the

Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook

2017-04-13 Thread Eric Wong
Jonathan Nieder wrote: > Brandon Williams wrote: > > The post-update hooks created in t5550-http-fetch-dumb.sh is missing the > > "!#/bin/sh" line which can cause issues with portability. Instead > > create the hook using the 'write_script' function which includes the > >

Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook

2017-04-13 Thread Jonathan Nieder
Hi, Brandon Williams wrote: > The post-update hooks created in t5550-http-fetch-dumb.sh is missing the > "!#/bin/sh" line which can cause issues with portability. Instead > create the hook using the 'write_script' function which includes the > proper "#!" line. > > Signed-off-by: Brandon

[PATCH v2 1/6] t5550: use write_script to generate post-update hook

2017-04-13 Thread Brandon Williams
The post-update hooks created in t5550-http-fetch-dumb.sh is missing the "!#/bin/sh" line which can cause issues with portability. Instead create the hook using the 'write_script' function which includes the proper "#!" line. Signed-off-by: Brandon Williams ---