Re: [PATCH v2 10/14] sequencer: lib'ify read_populate_opts()

Hi Junio, On Mon, 29 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Instead of dying there, let the caller high up in the callchain notice > > the error and handle it (by dying, still). > > > > The only caller of read_populate_opts(),

Re: [PATCH v2 10/14] sequencer: lib'ify read_populate_opts()

Junio C Hamano writes: >> +if (git_config_from_file(populate_opts_cb, git_path_opts_file(), *opts) >> < 0) >> +return error(_("Malformed options sheet: %s"), >> +git_path_opts_file()); >> +return 0; > > As discussed, perhaps have a

Re: [PATCH v2 10/14] sequencer: lib'ify read_populate_opts()

Johannes Schindelin writes: > Instead of dying there, let the caller high up in the callchain notice > the error and handle it (by dying, still). > > The only caller of read_populate_opts(), sequencer_continue() can > already return errors, so its caller must be

[PATCH v2 10/14] sequencer: lib'ify read_populate_opts()

Instead of dying there, let the caller high up in the callchain notice the error and handle it (by dying, still). The only caller of read_populate_opts(), sequencer_continue() can already return errors, so its caller must be already prepared to handle error returns, and with this step, we make it