Re: [PATCH v2 10/16] tag: change misleading --list documentation

2017-03-22 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Junio would you be fine with just this on top: > > diff --git a/t/README b/t/README > index 4982d1c521..9e079a360a 100644 > --- a/t/README > +++ b/t/README > @@ -379,2 +379,5 @@ Do: > > + - Include tests which assert that the desired &

Re: [PATCH v2 10/16] tag: change misleading --list documentation

2017-03-22 Thread Ævar Arnfjörð Bjarmason
On Wed, Mar 22, 2017 at 11:36 PM, Jeff King wrote: > On Wed, Mar 22, 2017 at 03:26:21PM -0700, Junio C Hamano wrote: > >> Ævar Arnfjörð Bjarmason writes: >> >> > of things you think we should be putting in the test suite. I.e. >> > should the tests be: >> > >> >

Re: [PATCH v2 10/16] tag: change misleading --list documentation

2017-03-22 Thread Jeff King
On Wed, Mar 22, 2017 at 03:26:21PM -0700, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > of things you think we should be putting in the test suite. I.e. > > should the tests be: > > > > a) Only be a collection of invocations of git we'd be comfortable > >

Re: [PATCH v2 10/16] tag: change misleading --list documentation

2017-03-22 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > of things you think we should be putting in the test suite. I.e. > should the tests be: > > a) Only be a collection of invocations of git we'd be comfortable > showing to someone as "this works, and this is how you should do it", > or things

Re: [PATCH v2 10/16] tag: change misleading --list documentation

2017-03-22 Thread Ævar Arnfjörð Bjarmason
On Wed, Mar 22, 2017 at 10:09 PM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >>> Please drop "interleaved", as we are not encouraging GNUism. We >>> just tolerate it but do not guarantee to keep them working. >> >> This brings up the same

Re: [PATCH v2 10/16] tag: change misleading --list documentation

2017-03-22 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Yes, all of this is correct, but not relevant to what I'm describing > in the commit message, because I'm making a documentation change and > describing how you *would* expect git to work if you read the > *documentation*, not if you read the

Re: [PATCH v2 10/16] tag: change misleading --list documentation

2017-03-22 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> Please drop "interleaved", as we are not encouraging GNUism. We >> just tolerate it but do not guarantee to keep them working. > > This brings up the same point you made in > , I replied to in >

Re: [PATCH v2 10/16] tag: change misleading --list documentation

2017-03-22 Thread Ævar Arnfjörð Bjarmason
On Tue, Mar 21, 2017 at 7:45 PM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> And after Jeff's change, one that took multiple patterns: >> >> git tag --list 'v*rc*' --list '*2.8*' > > I do not think this is a correct depiction of the

Re: [PATCH v2 10/16] tag: change misleading --list documentation

2017-03-21 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > And after Jeff's change, one that took multiple patterns: > > git tag --list 'v*rc*' --list '*2.8*' I do not think this is a correct depiction of the evolution, and is a confusing description. It should say git tag --list 'v*rc*'

[PATCH v2 10/16] tag: change misleading --list documentation

2017-03-21 Thread Ævar Arnfjörð Bjarmason
Change the documentation for --list so that it's described as a toggle, not as an option that takes a as an argument. Junio initially documented this in b867c7c23a ("git-tag: -l to list tags (usability).", 2006-02-17), but later Jeff King changed "tag" to accept multiple patterns in 588d0e834b