Re: [PATCH v2 12/16] parse-options: replace opterror() with optname()

2018-11-10 Thread Ramsay Jones
On 10/11/2018 04:55, Duy Nguyen wrote: > On Tue, Nov 6, 2018 at 3:07 PM Ramsay Jones > wrote: >> Also, this patch does not replace opterror() calls outside of >> the 'parse-options.c' file with optname(). This tickles my >> static-check.pl script, since optname() is an external function >>

Re: [PATCH v2 12/16] parse-options: replace opterror() with optname()

2018-11-09 Thread Duy Nguyen
On Tue, Nov 6, 2018 at 3:07 PM Ramsay Jones wrote: > Also, this patch does not replace opterror() calls outside of > the 'parse-options.c' file with optname(). This tickles my > static-check.pl script, since optname() is an external function > which is only called from 'parse-options.c'. > > So,

Re: [PATCH v2 12/16] parse-options: replace opterror() with optname()

2018-11-06 Thread Jeff King
On Tue, Nov 06, 2018 at 02:02:42PM +, Ramsay Jones wrote: > Also, this patch does not replace opterror() calls outside of > the 'parse-options.c' file with optname(). This tickles my > static-check.pl script, since optname() is an external function > which is only called from

Re: [PATCH v2 12/16] parse-options: replace opterror() with optname()

2018-11-06 Thread Ramsay Jones
On 06/11/2018 02:33, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> There are a few issues with opterror() >> >> - it tries to assemble an English sentence from pieces. This is not >> great for translators because we give them pieces instead of a full >> sentence. >> >> - It's

Re: [PATCH v2 12/16] parse-options: replace opterror() with optname()

2018-11-05 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > There are a few issues with opterror() > > - it tries to assemble an English sentence from pieces. This is not > great for translators because we give them pieces instead of a full > sentence. > > - It's a wrapper around error() and needs some hack to let the

[PATCH v2 12/16] parse-options: replace opterror() with optname()

2018-11-05 Thread Nguyễn Thái Ngọc Duy
There are a few issues with opterror() - it tries to assemble an English sentence from pieces. This is not great for translators because we give them pieces instead of a full sentence. - It's a wrapper around error() and needs some hack to let the compiler know it always returns -1. -