Re: [PATCH v2 13/17] remove_dir_recurse(): handle disappearing files and directories

2014-01-07 Thread Junio C Hamano
Michael Haggerty writes: > I'm not sure I understand your point. Please note that the > REMOVE_DIR_KEEP_TOPLEVEL bit is cleared from flags before this function > recurses. So in recursive invocations, keep_toplevel will always be > false, and the rmdir(path->buf) codepath will be permitted. Do

Re: [PATCH v2 13/17] remove_dir_recurse(): handle disappearing files and directories

2014-01-07 Thread Michael Haggerty
On 01/06/2014 07:18 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> If a file or directory that we are trying to remove disappears (e.g., >> because another process has pruned it), do not consider it an error. >> >> Signed-off-by: Michael Haggerty >> --- >> dir.c | 22

Re: [PATCH v2 13/17] remove_dir_recurse(): handle disappearing files and directories

2014-01-06 Thread Junio C Hamano
Michael Haggerty writes: > If a file or directory that we are trying to remove disappears (e.g., > because another process has pruned it), do not consider it an error. > > Signed-off-by: Michael Haggerty > --- > dir.c | 22 -- > 1 file changed, 16 insertions(+), 6 deletions(

[PATCH v2 13/17] remove_dir_recurse(): handle disappearing files and directories

2014-01-06 Thread Michael Haggerty
If a file or directory that we are trying to remove disappears (e.g., because another process has pruned it), do not consider it an error. Signed-off-by: Michael Haggerty --- dir.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/dir.c b/dir.c index 11e