Re: [PATCH v2 13/21] remote.c: report error on failure to fopen()

2017-05-09 Thread Johannes Schindelin
Hi Duy, On Tue, 9 May 2017, Duy Nguyen wrote: > Sorry for super late reply. I'm slowly catching up. > > On Wed, May 3, 2017 at 10:22 PM, Johannes Schindelin > wrote: > > Hi Duy, > > > > > > On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > > > >> There's plenty of

Re: [PATCH v2 13/21] remote.c: report error on failure to fopen()

2017-05-09 Thread Duy Nguyen
Sorry for super late reply. I'm slowly catching up. On Wed, May 3, 2017 at 10:22 PM, Johannes Schindelin wrote: > Hi Duy, > > > On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > >> There's plenty of error() in this code to safely assume --quiet is not a >> concern. >>

Re: [PATCH v2 13/21] remote.c: report error on failure to fopen()

2017-05-03 Thread Johannes Schindelin
Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > There's plenty of error() in this code to safely assume --quiet is not a > concern. > > t5512 needs update because if we check the path 'refs*master' (i.e. the > asterisk is part of the path) then we'll get an EINVAL error. So the

[PATCH v2 13/21] remote.c: report error on failure to fopen()

2017-05-03 Thread Nguyễn Thái Ngọc Duy
There's plenty of error() in this code to safely assume --quiet is not a concern. t5512 needs update because if we check the path 'refs*master' (i.e. the asterisk is part of the path) then we'll get an EINVAL error. Signed-off-by: Nguyễn Thái Ngọc Duy --- remote.c