Re: [PATCH v2 2/2] ls-files: fix path used when recursing into submodules

2017-04-18 Thread Stefan Beller
On Mon, Apr 17, 2017 at 7:03 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> From: Jacob Keller >> >> Don't assume that the current working directory is the root of the >> repository. Correctly generate the path for the

Re: [PATCH v2 2/2] ls-files: fix path used when recursing into submodules

2017-04-18 Thread Jacob Keller
On Mon, Apr 17, 2017 at 7:03 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> From: Jacob Keller >> >> Don't assume that the current working directory is the root of the >> repository. Correctly generate the path for the

Re: [PATCH v2 2/2] ls-files: fix path used when recursing into submodules

2017-04-17 Thread Junio C Hamano
Jacob Keller writes: > From: Jacob Keller > > Don't assume that the current working directory is the root of the > repository. Correctly generate the path for the recursing child > processes by building it from the work_tree() root instead.

Re: [PATCH v2 2/2] ls-files: fix path used when recursing into submodules

2017-04-13 Thread Jacob Keller
On Thu, Apr 13, 2017 at 11:15 AM, Stefan Beller wrote: > On Thu, Apr 13, 2017 at 10:12 AM, Jacob Keller > wrote: >> From: Jacob Keller >> >> Don't assume that the current working directory is the root of the >> repository. >

Re: [PATCH v2 2/2] ls-files: fix path used when recursing into submodules

2017-04-13 Thread Stefan Beller
On Thu, Apr 13, 2017 at 10:12 AM, Jacob Keller wrote: > From: Jacob Keller > > Don't assume that the current working directory is the root of the > repository. 1) Oh! This bug might be hidden in other commands, too. ($ git grep cp.dir --

Re: [PATCH v2 2/2] ls-files: fix path used when recursing into submodules

2017-04-13 Thread Brandon Williams
On 04/13, Jacob Keller wrote: > From: Jacob Keller > > Don't assume that the current working directory is the root of the > repository. Correctly generate the path for the recursing child > processes by building it from the work_tree() root instead. Otherwise if > we run

[PATCH v2 2/2] ls-files: fix path used when recursing into submodules

2017-04-13 Thread Jacob Keller
From: Jacob Keller Don't assume that the current working directory is the root of the repository. Correctly generate the path for the recursing child processes by building it from the work_tree() root instead. Otherwise if we run ls-files using --git-dir or --work-tree it