Re: [PATCH v2 2/2] stash push -u: don't create empty stash

2018-03-16 Thread Thomas Gummerer
On 03/15, Junio C Hamano wrote: > Thomas Gummerer writes: > > > no_changes () { > > git diff-index --quiet --cached HEAD --ignore-submodules -- "$@" && > > git diff-files --quiet --ignore-submodules -- "$@" && > > - (test -z "$untracked" || test -z

Re: [PATCH v2 2/2] stash push -u: don't create empty stash

2018-03-15 Thread Junio C Hamano
Thomas Gummerer writes: > no_changes () { > git diff-index --quiet --cached HEAD --ignore-submodules -- "$@" && > git diff-files --quiet --ignore-submodules -- "$@" && > - (test -z "$untracked" || test -z "$(untracked_files)") > + (test -z "$untracked"

[PATCH v2 2/2] stash push -u: don't create empty stash

2018-03-14 Thread Thomas Gummerer
When introducing the stash push feature, and thus allowing users to pass in a pathspec to limit the files that would get stashed in df6bba0937 ("stash: teach 'push' (and 'create_stash') to honor pathspec", 2017-02-28), this developer missed one place where the pathspec should be passed in. Namely