Re: [PATCH v2 2/3] environment: add GIT_PREFIX to local_repo_env

2013-03-08 Thread Junio C Hamano
Jeff King writes: > On Fri, Mar 08, 2013 at 04:39:02PM -0500, Eric Sunshine wrote: > >> On Fri, Mar 8, 2013 at 4:30 AM, Jeff King wrote: >> > The GIT_PREFIX variable is set based on our location within >> > the working tree. It should therefore be cleared whenever >> > GIT_WORK_TREE is cleared.

Re: [PATCH v2 2/3] environment: add GIT_PREFIX to local_repo_env

2013-03-08 Thread Jeff King
On Fri, Mar 08, 2013 at 04:39:02PM -0500, Eric Sunshine wrote: > On Fri, Mar 8, 2013 at 4:30 AM, Jeff King wrote: > > The GIT_PREFIX variable is set based on our location within > > the working tree. It should therefore be cleared whenever > > GIT_WORK_TREE is cleared. > > > > In practice, this d

Re: [PATCH v2 2/3] environment: add GIT_PREFIX to local_repo_env

2013-03-08 Thread Eric Sunshine
On Fri, Mar 8, 2013 at 4:30 AM, Jeff King wrote: > The GIT_PREFIX variable is set based on our location within > the working tree. It should therefore be cleared whenever > GIT_WORK_TREE is cleared. > > In practice, this doesn't cause any bugs, because none of > the sub-programs we invoke with loc

[PATCH v2 2/3] environment: add GIT_PREFIX to local_repo_env

2013-03-08 Thread Jeff King
The GIT_PREFIX variable is set based on our location within the working tree. It should therefore be cleared whenever GIT_WORK_TREE is cleared. In practice, this doesn't cause any bugs, because none of the sub-programs we invoke with local_repo_env cleared actually care about GIT_PREFIX. But this