Re: [PATCH v2 2/3] gitk: write only changed configuration variables

2014-10-30 Thread Paul Mackerras
On Sun, Sep 14, 2014 at 11:35:58PM +0300, Max Kirillov wrote: When gitk contains some changed parameter, and there is existing instance of gitk where the parameter is still old, it is reverted to that old value when the instance exits. Instead, store a parameter in config only it is has been

Re: [PATCH v2 2/3] gitk: write only changed configuration variables

2014-10-30 Thread Max Kirillov
Hi. On Thu, Oct 30, 2014 at 08:55:13PM +1100, Paul Mackerras wrote: It seems to me that we need the trace only for the non-array configuration variables; the array case is only for the view definitions, and I think we could just set the changed flag for a view explicitly in [newviewok]. That

[PATCH v2 2/3] gitk: write only changed configuration variables

2014-09-14 Thread Max Kirillov
When gitk contains some changed parameter, and there is existing instance of gitk where the parameter is still old, it is reverted to that old value when the instance exits. Instead, store a parameter in config only it is has been modified in the exiting instance. Otherwise, preserve the value