Re: [PATCH v2 2/3] sha1_file: implement changes for "cat-file --literally -t"

2015-03-04 Thread Junio C Hamano
karthik nayak writes: >> Looks suspiciously familiar... > Yes, you suggested it. > It has a similar structure to unpack_sha1_header(). > Anything wrong with it? I don't know if there is something wrong with the code, or not, but it wasn't mentioned in the log message at all that it is not your c

Re: [PATCH v2 2/3] sha1_file: implement changes for "cat-file --literally -t"

2015-03-04 Thread karthik nayak
On 03/05/2015 02:28 AM, Junio C Hamano wrote: Karthik Nayak writes: > add "sha1_object_info_literally()" which is to be used when > the "literally" option is given to get the type of object > and print it, using "sha1_object_info_extended()". > > add "unpack_sha1_header_literally()" to unpack

Re: [PATCH v2 2/3] sha1_file: implement changes for "cat-file --literally -t"

2015-03-04 Thread Junio C Hamano
Karthik Nayak writes: > add "sha1_object_info_literally()" which is to be used when > the "literally" option is given to get the type of object > and print it, using "sha1_object_info_extended()". > > add "unpack_sha1_header_literally()" to unpack sha headers > which may be greater than 32 bytes,

[PATCH v2 2/3] sha1_file: implement changes for "cat-file --literally -t"

2015-03-03 Thread Karthik Nayak
add "sha1_object_info_literally()" which is to be used when the "literally" option is given to get the type of object and print it, using "sha1_object_info_extended()". add "unpack_sha1_header_literally()" to unpack sha headers which may be greater than 32 bytes, which is the threshold for a regul