Re: [PATCH v2 22/24] revision.c: remove implicit dependency on the_index

2018-09-04 Thread Junio C Hamano
Stefan Beller writes: >> - init_revisions(revs, prefix); >> + init_revisions(revs, the_repository, prefix); > > Thanks for this patch! > > At first I wondered why we put the repository as the second argument, > but that comes down to personal preference, so I wanted to keep it silent.

Re: [PATCH v2 22/24] revision.c: remove implicit dependency on the_index

2018-09-04 Thread Stefan Beller
On Mon, Sep 3, 2018 at 11:10 AM Nguyễn Thái Ngọc Duy wrote: > > "remove" is probably a strong word because the dependency is still > there, hidden behind the_repository. This patch is almost mechanical, > all call sites are updated to take the_repository, no exception. > > Signed-off-by: Nguyễn Th

[PATCH v2 22/24] revision.c: remove implicit dependency on the_index

2018-09-03 Thread Nguyễn Thái Ngọc Duy
"remove" is probably a strong word because the dependency is still there, hidden behind the_repository. This patch is almost mechanical, all call sites are updated to take the_repository, no exception. Signed-off-by: Nguyễn Thái Ngọc Duy --- bisect.c | 4 ++-- builtin/ad