Matthieu Moy writes:
> If implementing a proper count is too hard, one option is to forbid
> --count -S and --count -G to avoid confusion.
Let's not go there. Letting people to use "--oneline | wc -l" is
far better unless we can get --count that behaves the same as that,
only faster.
--
To unsu
Matthieu Moy writes:
> Also, some revision-limiting options can reduce the count like
>
> git log --grep whatever
>
> and you should check that you actually count the right number here.
>
> (I don't know this part of the code enough, but I'm not sure you
> actually deal with this properly)
Yes,
Matthieu Moy writes:
> Also, some revision-limiting options can reduce the count like
>
> git log --grep whatever
OK, --grep seems to work, but -S and -G do not:
$ ./bin-wrappers/git log -Sfoo --count
40012
$ ./bin-wrappers/git log -Sfoo --oneline | wc -l
925
$ ./bin-wrappers/git log --count
Lawrence Siebert writes:
> Ok, I'll fix that.
(Note: this is a typical example of why we don't top-post here. I made
several remarks and I can't know what "that" refers to)
(Meta-note: don't take the note as agressive, I know that top-posting is
the norm in many other places, I'm just giving yo
Matthieu,
Ok, I'll fix that. I think I can also add tests, I can look at the
tests for rev-list --count, with the understanding that I saw somebody
else had made changes for the --use-bitmap-index option, and I am
basing off of master for this, and thus don't feel comfortable with
--use-bitmap-i
Lawrence Siebert writes:
> added test comparing output between git log --count HEAD and
> git rev-list --count HEAD
Unless there is a very long list of tests, I'd rather see this squashed
with PATCH 2/4. As a reviewer I prefer having code and tests in the same
place.
> Signed-off-by: Lawrence S
added test comparing output between git log --count HEAD and
git rev-list --count HEAD
Signed-off-by: Lawrence Siebert
---
t/t4202-log.sh | 7 +++
1 file changed, 7 insertions(+)
diff --git a/t/t4202-log.sh b/t/t4202-log.sh
index 1b2e981..35f8d82 100755
--- a/t/t4202-log.sh
+++ b/t/t4202-lo
7 matches
Mail list logo
