Re: [PATCH v2 3/5] index-pack: check (and optionally set) hash algo based on input file

2018-02-24 Thread brian m. carlson
On Sat, Feb 24, 2018 at 10:34:27AM +0700, Nguyễn Thái Ngọc Duy wrote: > After 454253f059 (builtin/index-pack: improve hash function abstraction > - 2018-02-01), index-pack uses the_hash_algo for hashing. If "git > index-pack" is executed without a repository, we do not know what hash > algorithm

[PATCH v2 3/5] index-pack: check (and optionally set) hash algo based on input file

2018-02-23 Thread Nguyễn Thái Ngọc Duy
After 454253f059 (builtin/index-pack: improve hash function abstraction - 2018-02-01), index-pack uses the_hash_algo for hashing. If "git index-pack" is executed without a repository, we do not know what hash algorithm to be used and the_hash_algo in theory could be undefined. Since there should