Re: [PATCH v2 4/4] builtin/rebase: support running "git rebase "

2018-07-03 Thread Junio C Hamano
Pratik Karki writes: > +static struct commit *peel_committish(const char *name) > +{ > + struct object *obj; > + struct object_id oid; It by itself is not a big enough deal to warrant a reroll, but please make it a habit to leave a blank line between the declarations and the first statem

[PATCH v2 4/4] builtin/rebase: support running "git rebase "

2018-07-02 Thread Pratik Karki
This patch gives life to the skeleton added in the previous patch. This patch makes real operation happen i.e. by using `git -c rebase.usebuiltin=true rebase `. With this patch, the basic operation of rebase can be done. The current version of the builtin rebase does not, however, make full use of