Re: [PATCH v2 4/4] diff: mark any file larger than core.bigfilethreshold binary

On Sat, Jun 28, 2014 at 1:56 AM, Thomas Braun thomas.br...@virtuell-zuhause.de wrote: The name is misleading and forced me to read it twice before I realized that this is populating the is-binary bit. It might make it a bit better if you renamed it to DIFF_POPULATE_IS_BINARY_BIT or perhaps

Re: [PATCH v2 4/4] diff: mark any file larger than core.bigfilethreshold binary

Am 26.06.2014 19:55, schrieb Junio C Hamano: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Too large files may lead to failure to allocate memory. If it happens here, it could impact quite a few commands that involve diff. Moreover, too large files are inefficient to compare anyway (and

Re: [PATCH v2 4/4] diff: mark any file larger than core.bigfilethreshold binary

Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Too large files may lead to failure to allocate memory. If it happens here, it could impact quite a few commands that involve diff. Moreover, too large files are inefficient to compare anyway (and most likely non-text), so mark them binary and

[PATCH v2 4/4] diff: mark any file larger than core.bigfilethreshold binary

Too large files may lead to failure to allocate memory. If it happens here, it could impact quite a few commands that involve diff. Moreover, too large files are inefficient to compare anyway (and most likely non-text), so mark them binary and skip looking at their content. Noticed-by: Dale R.