Re: [PATCH v2 4/4] diff: use skip_to_optional_val_default()

2017-12-04 Thread Junio C Hamano
Christian Couder writes: > - } else if (!strcmp(arg, "--submodule")) > - options->submodule_format = DIFF_SUBMODULE_LOG; > - else if (skip_prefix(arg, "--submodule=", &arg)) > + } else if (skip_to_optional_val_default(arg, "--submodule", &arg, > "log")) > re

[PATCH v2 4/4] diff: use skip_to_optional_val_default()

2017-12-04 Thread Christian Couder
Let's simplify diff option parsing using skip_to_optional_val_default(). Signed-off-by: Christian Couder --- diff.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/diff.c b/diff.c index 83509f0658..d234b4f0cb 100644 --- a/diff.c +++ b/diff.c @@ -4619,9 +