Re: [PATCH v2 42/43] refs: add LMDB refs backend

2015-10-07 Thread Michael Haggerty
On 10/07/2015 09:20 PM, David Turner wrote: > On Wed, 2015-10-07 at 20:31 +0200, Michael Haggerty wrote: >> [...] >> I'm really happy about your work. >> >> Regarding strategy: I think a good approach would be to get as much of >> the preparatory work as possible (the abstraction and separation of

Re: [PATCH v2 42/43] refs: add LMDB refs backend

2015-10-07 Thread David Turner
On Wed, 2015-10-07 at 20:31 +0200, Michael Haggerty wrote: > On 10/07/2015 03:51 AM, David Turner wrote: > > On Mon, 2015-10-05 at 17:47 +0200, Michael Haggerty wrote: > >> On 09/29/2015 12:02 AM, David Turner wrote: > >>> Add a database backend for refs using LMDB. [...] > >> > >> I think you

Re: [PATCH v2 42/43] refs: add LMDB refs backend

2015-10-07 Thread Junio C Hamano
Michael Haggerty writes: > I'm really happy about your work. > > Regarding strategy: I think a good approach would be to get as much of > the preparatory work as possible (the abstraction and separation of > refs-be-files) to the point where it can be merged before there is

Re: [PATCH v2 42/43] refs: add LMDB refs backend

2015-10-07 Thread Michael Haggerty
On 10/07/2015 03:51 AM, David Turner wrote: > On Mon, 2015-10-05 at 17:47 +0200, Michael Haggerty wrote: >> On 09/29/2015 12:02 AM, David Turner wrote: >>> Add a database backend for refs using LMDB. [...] >> >> I think you have said before that if one writer holds the write lock on >> the DB,

Re: [PATCH v2 42/43] refs: add LMDB refs backend

2015-10-06 Thread David Turner
On Mon, 2015-10-05 at 17:47 +0200, Michael Haggerty wrote: > On 09/29/2015 12:02 AM, David Turner wrote: > > Add a database backend for refs using LMDB. This backend runs git > > for-each-ref about 30% faster than the files backend with fully-packed > > refs on a repo with ~120k refs. It's also

Re: [PATCH v2 42/43] refs: add LMDB refs backend

2015-10-05 Thread Michael Haggerty
On 09/29/2015 12:02 AM, David Turner wrote: > Add a database backend for refs using LMDB. This backend runs git > for-each-ref about 30% faster than the files backend with fully-packed > refs on a repo with ~120k refs. It's also about 4x faster than using > fully-unpacked refs. In addition, and

Re: [PATCH v2 42/43] refs: add LMDB refs backend

2015-10-02 Thread Junio C Hamano
David Turner writes: > diff --git a/refs-be-lmdb.c b/refs-be-lmdb.c > new file mode 100644 > index 000..99cbd29 > --- /dev/null > +++ b/refs-be-lmdb.c > @@ -0,0 +1,2003 @@ > +/* > + ... > + */ > +#include > +#include > +#include "cache.h" "git-compat-util.h" (or

[PATCH v2 42/43] refs: add LMDB refs backend

2015-09-28 Thread David Turner
Add a database backend for refs using LMDB. This backend runs git for-each-ref about 30% faster than the files backend with fully-packed refs on a repo with ~120k refs. It's also about 4x faster than using fully-unpacked refs. In addition, and perhaps more importantly , it avoids case-conflict