Re: [PATCH v2 5/6] submodule-config: pass repository as argument to config_from_gitmodules

2018-06-26 Thread Antonio Ospite
On Tue, 26 Jun 2018 13:15:33 -0700 Junio C Hamano wrote: > Antonio Ospite writes: > > > Generlize config_from_gitmodules to accept a repository as an argument. > > generalize??? > Of course I was going to miss a typo in the first word of the commit message :| If this is the only change,

Re: [PATCH v2 5/6] submodule-config: pass repository as argument to config_from_gitmodules

2018-06-26 Thread Junio C Hamano
Antonio Ospite writes: > Generlize config_from_gitmodules to accept a repository as an argument. generalize??? > > This is in preparation to reuse the function in repo_read_gitmodules in > order to have a single point where the '.gitmodules' file is accessed. > > Signed-off-by: Antonio Ospite

[PATCH v2 5/6] submodule-config: pass repository as argument to config_from_gitmodules

2018-06-26 Thread Antonio Ospite
Generlize config_from_gitmodules to accept a repository as an argument. This is in preparation to reuse the function in repo_read_gitmodules in order to have a single point where the '.gitmodules' file is accessed. Signed-off-by: Antonio Ospite --- submodule-config.c | 10 +- 1 file