Re: [PATCH v2 7/8] revert/cherry-pick: add --quiet option

2013-06-03 Thread Junio C Hamano
Makes sense. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 7/8] revert/cherry-pick: add --quiet option

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 8:32 AM, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: >> Did you miss the -q option passed to 'git commit'? > > Ah, yes. > > It would help if you mentioned: > > Introduce --quiet to suppress warning about skipped commits (when > using --skip-empty) and output f

Re: [PATCH v2 7/8] revert/cherry-pick: add --quiet option

2013-05-29 Thread Ramkumar Ramachandra
Felipe Contreras wrote: > Did you miss the -q option passed to 'git commit'? Ah, yes. It would help if you mentioned: Introduce --quiet to suppress warning about skipped commits (when using --skip-empty) and output from 'git commit'. in the commit message. Thanks. -- To unsubscribe from th

Re: [PATCH v2 7/8] revert/cherry-pick: add --quiet option

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 7:33 AM, Ramkumar Ramachandra wrote: > Felipe Contreras wrote: >> if (opts->skip_empty && is_index_unchanged() == 1) { >> - warning(_("skipping %s... %s"), >> - find_unique_abbrev(commit->object.sha1, >> DEFAULT_ABBREV), >> -

Re: [PATCH v2 7/8] revert/cherry-pick: add --quiet option

2013-05-29 Thread Ramkumar Ramachandra
Felipe Contreras wrote: > if (opts->skip_empty && is_index_unchanged() == 1) { > - warning(_("skipping %s... %s"), > - find_unique_abbrev(commit->object.sha1, > DEFAULT_ABBREV), > - msg.subject); > + if (!opts->quiet)

[PATCH v2 7/8] revert/cherry-pick: add --quiet option

2013-05-28 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- Documentation/git-cherry-pick.txt | 6 +- Documentation/git-revert.txt | 6 +- builtin/revert.c | 1 + sequencer.c | 9 ++--- sequencer.h | 1 + 5 files changed, 18 insertions(+), 5 d