Re: [PATCH v2 8/8] travis-ci: only print test failures if there are

2017-12-16 Thread Eric Sunshine
On Sat, Dec 16, 2017 at 5:48 PM, SZEDER Gábor wrote: > On Sat, Dec 16, 2017, Eric Sunshine wrote: >> I'd think you'd want to capture the result of the expansion of >> t/test-result/*.exit as a string and compare that instead. > > I'm not sure how

Re: [PATCH v2 8/8] travis-ci: only print test failures if there are

2017-12-16 Thread SZEDER Gábor
> On Sat, Dec 16, 2017 at 7:58 AM, SZEDER G=C3=A1bor w= > rote: > > +if test t/test-results/*.exit =3D "t/test-results/*.exit" > > Isn't the above going to cause 'test' to error out? > > $ mkdir -p t/test-results > $ >t/test-results/a.exit > $

Re: [PATCH v2 8/8] travis-ci: only print test failures if there are test results available

2017-12-16 Thread Eric Sunshine
On Sat, Dec 16, 2017 at 7:58 AM, SZEDER Gábor wrote: > When a build job running the test suite fails, our > 'ci/print-test-failures.sh' script scans all 't/test-results/*.exit' > files to find failed tests and prints their verbose output. However, > if a build job were to

[PATCH v2 8/8] travis-ci: only print test failures if there are test results available

2017-12-16 Thread SZEDER Gábor
When a build job running the test suite fails, our 'ci/print-test-failures.sh' script scans all 't/test-results/*.exit' files to find failed tests and prints their verbose output. However, if a build job were to fail before it ever gets to run the test suite, then there will be no files to match