Re: [PATCH v2 8/9] gpg-interface: introduce new signature format "x509" using gpgsm

2018-07-11 Thread Henning Schild
Am Tue, 10 Jul 2018 13:01:10 -0400 schrieb Jeff King : > On Tue, Jul 10, 2018 at 10:52:30AM +0200, Henning Schild wrote: > > > diff --git a/Documentation/config.txt b/Documentation/config.txt > > index c0bd80954..b6f9b47d5 100644 > > --- a/Documentation/config.txt > > +++

Re: [PATCH v2 8/9] gpg-interface: introduce new signature format "x509" using gpgsm

2018-07-10 Thread Junio C Hamano
Jeff King writes: >> @@ -16,13 +16,18 @@ struct gpg_format_data { >> >> #define PGP_SIGNATURE "-BEGIN PGP SIGNATURE-" >> #define PGP_MESSAGE "-BEGIN PGP MESSAGE-" >> +#define X509_SIGNATURE "-BEGIN SIGNED MESSAGE-" >> >> -enum gpgformats { PGP_FMT }; >> +enum

Re: [PATCH v2 8/9] gpg-interface: introduce new signature format "x509" using gpgsm

2018-07-10 Thread Jeff King
On Tue, Jul 10, 2018 at 10:40:22AM -0700, Junio C Hamano wrote: > > Extremely minor nit, but if there are no other uses of PGP_SIGNATURE etc > > outside of this array (as I hope there wouldn't be after this series), > > would it make more sense to just include the literals inline in the > > array

Re: [PATCH v2 8/9] gpg-interface: introduce new signature format "x509" using gpgsm

2018-07-10 Thread Jeff King
On Tue, Jul 10, 2018 at 10:52:30AM +0200, Henning Schild wrote: > diff --git a/Documentation/config.txt b/Documentation/config.txt > index c0bd80954..b6f9b47d5 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -1830,7 +1830,7 @@ gpg.program:: > > gpg.format:: >

[PATCH v2 8/9] gpg-interface: introduce new signature format "x509" using gpgsm

2018-07-10 Thread Henning Schild
This commit allows git to create and check x509 type signatures using gpgsm. Signed-off-by: Henning Schild --- Documentation/config.txt | 2 +- gpg-interface.c | 10 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/config.txt