Re: [PATCH v3] fetch-pack: always allow fetching of literal SHA1s

2017-05-13 Thread Jeff King
On Thu, May 11, 2017 at 10:00:50AM -0700, Brandon Williams wrote: > > None of this is your problem now either way; the advertisement-limiting > > extension is still vaporware, albeit one we've discussed a lot. I just > > wanted to make sure we weren't painting ourselves into any corners. And > >

Re: [PATCH v3] fetch-pack: always allow fetching of literal SHA1s

2017-05-11 Thread Jeff King
On Thu, May 11, 2017 at 10:51:37AM -0700, Jonathan Tan wrote: > > This is inside the nr_sought loop. So if I were to do: > > > > git fetch origin $(git ls-remote origin | awk '{print $1}') > > > > we're back to being quadratic. I realize that's probably a silly thing > > to do, but in the

Re: [PATCH v3] fetch-pack: always allow fetching of literal SHA1s

2017-05-11 Thread Jonathan Tan
Thanks for your suggestions. I'll hold off on sending out a new patch (following Jonathan Nieder's suggestions [1]) until we decide if further optimizations (for example, as suggested by Peff) need to be done. [1] <20170510232231.gc28...@aiede.svl.corp.google.com> On 05/11/2017 02:46 AM, Jeff

Re: [PATCH v3] fetch-pack: always allow fetching of literal SHA1s

2017-05-11 Thread Brandon Williams
On 05/11, Jeff King wrote: > On Wed, May 10, 2017 at 03:11:57PM -0700, Jonathan Tan wrote: > > > fetch-pack, when fetching a literal SHA-1 from a server that is not > > configured with uploadpack.allowtipsha1inwant (or similar), always > > returns an error message of the form "Server does not

Re: [PATCH v3] fetch-pack: always allow fetching of literal SHA1s

2017-05-11 Thread Jeff King
On Wed, May 10, 2017 at 03:11:57PM -0700, Jonathan Tan wrote: > fetch-pack, when fetching a literal SHA-1 from a server that is not > configured with uploadpack.allowtipsha1inwant (or similar), always > returns an error message of the form "Server does not allow request for > unadvertised object

Re: [PATCH v3] fetch-pack: always allow fetching of literal SHA1s

2017-05-11 Thread Jeff King
On Wed, May 10, 2017 at 03:11:57PM -0700, Jonathan Tan wrote: > After looking at ways to solve jrnieder's performance concerns, if we're > going to need to manage one more item of state within the function, I > might as well use my earlier idea of storing unmatched refs in its own > list instead

Re: [PATCH v3] fetch-pack: always allow fetching of literal SHA1s

2017-05-10 Thread Jonathan Nieder
Hi, Jonathan Tan wrote: > fetch-pack, when fetching a literal SHA-1 from a server that is not > configured with uploadpack.allowtipsha1inwant (or similar), always > returns an error message of the form "Server does not allow request for > unadvertised object %s". However, it is sometimes the

[PATCH v3] fetch-pack: always allow fetching of literal SHA1s

2017-05-10 Thread Jonathan Tan
fetch-pack, when fetching a literal SHA-1 from a server that is not configured with uploadpack.allowtipsha1inwant (or similar), always returns an error message of the form "Server does not allow request for unadvertised object %s". However, it is sometimes the case that such object is advertised.