Re: [PATCH v3] gpg-interface.c: detect and reject multiple signatures on commits

2018-10-15 Thread Junio C Hamano
Michał Górny writes: >> OK, so the whole thing makes sense to me. >> >> Having said that, if we wanted to short-circuit, I think >> >> for (each line) { >> for (each sigcheck_gpg_status[]) { >> if (not the one on line) >>

Re: [PATCH v3] gpg-interface.c: detect and reject multiple signatures on commits

2018-10-15 Thread Michał Górny
On Mon, 2018-10-15 at 12:31 +0900, Junio C Hamano wrote: > Michał Górny writes: > > > GnuPG supports creating signatures consisting of multiple signature > > packets. If such a signature is verified, it outputs all the status > > messages for each signature separately. However, git currently

Re: [PATCH v3] gpg-interface.c: detect and reject multiple signatures on commits

2018-10-14 Thread Junio C Hamano
Michał Górny writes: > GnuPG supports creating signatures consisting of multiple signature > packets. If such a signature is verified, it outputs all the status > messages for each signature separately. However, git currently does not > account for such scenario and gets terribly confused over

Re: [PATCH v3] gpg-interface.c: detect and reject multiple signatures on commits

2018-10-14 Thread Junio C Hamano
Thanks, will take a look.

[PATCH v3] gpg-interface.c: detect and reject multiple signatures on commits

2018-10-12 Thread Michał Górny
GnuPG supports creating signatures consisting of multiple signature packets. If such a signature is verified, it outputs all the status messages for each signature separately. However, git currently does not account for such scenario and gets terribly confused over getting multiple *SIG