Re: [PATCH v3] remotes-hg: bugfix for fetching non local remotes

2013-07-26 Thread Jörn Hees
On 25 Jul 2013, at 21:12, Felipe Contreras wrote: >> […] >> --- >> contrib/remote-helpers/git-remote-hg | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/contrib/remote-helpers/git-remote-hg >> b/contrib/remote-helpers/git-remote-hg >> index 0194c67..f4e9d1c 100755 >> -

Re: [PATCH v3] remotes-hg: bugfix for fetching non local remotes

2013-07-26 Thread Jörn Hees
On 25 Jul 2013, at 23:10, Antoine Pelisse wrote: > On Thu, Jul 25, 2013 at 10:40 PM, Felipe Contreras > wrote: >> That's true. Maybe something like: >> >> for x in repos: >> local_hg = os.path.join(shared_path, x, 'clone', '.hg') >> if os.path.exists(local_hg): >>shutil.copytree(local_hg,

Re: [PATCH v3] remotes-hg: bugfix for fetching non local remotes

2013-07-25 Thread Junio C Hamano
Antoine Pelisse writes: > On Thu, Jul 25, 2013 at 10:40 PM, Felipe Contreras > wrote: >> That's true. Maybe something like: >> >> for x in repos: >> local_hg = os.path.join(shared_path, x, 'clone', '.hg') >> if os.path.exists(local_hg): >> shutil.copytree(local_hg, hg_path) >> break

Re: [PATCH v3] remotes-hg: bugfix for fetching non local remotes

2013-07-25 Thread Antoine Pelisse
On Thu, Jul 25, 2013 at 10:40 PM, Felipe Contreras wrote: > That's true. Maybe something like: > > for x in repos: > local_hg = os.path.join(shared_path, x, 'clone', '.hg') > if os.path.exists(local_hg): > shutil.copytree(local_hg, hg_path) > break I think that would work, but I think

Re: [PATCH v3] remotes-hg: bugfix for fetching non local remotes

2013-07-25 Thread Felipe Contreras
On Thu, Jul 25, 2013 at 2:53 PM, Antoine Pelisse wrote: > On Thu, Jul 25, 2013 at 9:12 PM, Felipe Contreras > wrote: >> Besides, I don't see >> the point of having a '.shared/.hg' directory, and nothing else on >> that '.shared' folder. > > Is it not already true about the ".git/hg/$alias/clone/"

Re: [PATCH v3] remotes-hg: bugfix for fetching non local remotes

2013-07-25 Thread Antoine Pelisse
On Thu, Jul 25, 2013 at 9:12 PM, Felipe Contreras wrote: > Besides, I don't see > the point of having a '.shared/.hg' directory, and nothing else on > that '.shared' folder. Is it not already true about the ".git/hg/$alias/clone/" directory ? > So, here's my patch. If only Junio read them. > > S

Re: [PATCH v3] remotes-hg: bugfix for fetching non local remotes

2013-07-25 Thread Felipe Contreras
On Wed, Jul 24, 2013 at 7:42 PM, Joern Hees wrote: > 6796d49 introduced a bug by making shared_path == ".git/hg' which > will most likely exist already, causing a new remote never to be > cloned and subsequently causing hg.share to fail with error msg: > "mercurial.error.RepoError: repository .git

[PATCH v3] remotes-hg: bugfix for fetching non local remotes

2013-07-24 Thread Joern Hees
6796d49 introduced a bug by making shared_path == ".git/hg' which will most likely exist already, causing a new remote never to be cloned and subsequently causing hg.share to fail with error msg: "mercurial.error.RepoError: repository .git/hg not found" Changing shared_path to ".git/hg/.shared" wi