Re: [PATCH v3] run-command: add hint when a hook is ignored

2018-03-05 Thread Junio C Hamano
Jeff King writes: >> True. The user could tell the server operator to rename them or >> remove them because they are not doing anything useful, but then >> as long as everybody knows they are not doing anything, it is OK >> to leave that sleeping dog lie, as they are not doing anything >> harmfu

Re: [PATCH v3] run-command: add hint when a hook is ignored

2018-03-02 Thread Jeff King
On Fri, Jan 05, 2018 at 11:36:39AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > The problem is that I was bisecting an unrelated change in old code, and > > I built a commit which predates f98f8cbac0 (Ship sample hooks with .sample > > suffix, 2008-06-24). That wrote a bare "update" fi

Re: [PATCH v3] run-command: add hint when a hook is ignored

2018-01-05 Thread Junio C Hamano
Jeff King writes: > The problem is that I was bisecting an unrelated change in old code, and > I built a commit which predates f98f8cbac0 (Ship sample hooks with .sample > suffix, 2008-06-24). That wrote a bare "update" file into templates/blt > (without the ".sample" suffix). After that, the cru

Re: [PATCH v3] run-command: add hint when a hook is ignored

2018-01-03 Thread Jeff King
On Wed, Oct 11, 2017 at 03:26:43PM +0900, Junio C Hamano wrote: > Junio C Hamano writes: > > > Quite honestly, I do not particulary think this is confusing, and I > > expect that this change will irritate many people by forcing them to > > either set the advise config or move the ones that they

Re: [PATCH v3] run-command: add hint when a hook is ignored

2017-10-10 Thread Junio C Hamano
Junio C Hamano writes: > Quite honestly, I do not particulary think this is confusing, and I > expect that this change will irritate many people by forcing them to > either set the advise config or move the ones that they deliberately > left unexecutable by renaming them by adding ".disabled" at

Re: [PATCH v3] run-command: add hint when a hook is ignored

2017-10-09 Thread Junio C Hamano
Damien MariƩ writes: > When an hook is present but the file is not set as executable then git will > ignore the hook. > For now this is silent which can be confusing. Quite honestly, I do not particulary think this is confusing, and I expect that this change will irritate many people by forcing

[PATCH v3] run-command: add hint when a hook is ignored

2017-10-06 Thread Damien MariƩ
When an hook is present but the file is not set as executable then git will ignore the hook. For now this is silent which can be confusing. This commit adds this warning to improve the situation: hint: The 'pre-commit' hook was ignored because it's not set as executable. hint: You can disable