Re: [PATCH v3] trailer: support multiline title

2015-08-31 Thread Christian Couder
On Mon, Aug 31, 2015 at 8:13 PM, Junio C Hamano wrote: > Christian Couder writes: > >> On Mon, Aug 31, 2015 at 10:38 AM, Matthieu Moy >> wrote: >>> Christian Couder writes: >>> That's why instead of ignoring only the first line, it is better to ignore the first paragraph. --- >>>

Re: [PATCH v3] trailer: support multiline title

2015-08-31 Thread Junio C Hamano
Christian Couder writes: > We currently ignore the first line passed to `git interpret-trailers`, > when looking for the beginning of the trailers. > > Unfortunately this does not work well when a commit is created with a > line break in the title, using for example the following command: > > git

Re: [PATCH v3] trailer: support multiline title

2015-08-31 Thread Junio C Hamano
Christian Couder writes: > On Mon, Aug 31, 2015 at 10:38 AM, Matthieu Moy > wrote: >> Christian Couder writes: >> >>> That's why instead of ignoring only the first line, it is better to >>> ignore the first paragraph. >>> --- >> >> Lacks sign-off again. > > Ooops, sorry. Let me forge one just

Re: [PATCH v3] trailer: support multiline title

2015-08-31 Thread Matthieu Moy
Christian Couder writes: > This first patch is already in master. That's why I only sent the > second one. But yeah I could have explained that after the three > dashes. OK, my bad, I should have "git fetch"ed. Thanks, -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from th

Re: [PATCH v3] trailer: support multiline title

2015-08-31 Thread Christian Couder
On Mon, Aug 31, 2015 at 10:38 AM, Matthieu Moy wrote: > Christian Couder writes: > >> That's why instead of ignoring only the first line, it is better to >> ignore the first paragraph. >> --- > > Lacks sign-off again. Ooops, sorry. > This replaces PATCH 2/2 in your previous series, but requires

Re: [PATCH v3] trailer: support multiline title

2015-08-31 Thread Matthieu Moy
Christian Couder writes: > That's why instead of ignoring only the first line, it is better to > ignore the first paragraph. > --- Lacks sign-off again. This replaces PATCH 2/2 in your previous series, but requires PATCH 1/2, right? If so that would be simpler to resend both patches IMHO. The

[PATCH v3] trailer: support multiline title

2015-08-30 Thread Christian Couder
We currently ignore the first line passed to `git interpret-trailers`, when looking for the beginning of the trailers. Unfortunately this does not work well when a commit is created with a line break in the title, using for example the following command: git commit -m 'place of code: change we ma