Re: [PATCH v3] wildmatch: properly fold case everywhere

2013-05-29 Thread Duy Nguyen
On Thu, May 30, 2013 at 12:57 AM, Anthony Ramine wrote: >>> If the range to match against is [A-_], it will become [a-_] which is an >>> empty range, ord('a') > ord('_'). I think it is simpler to reuse toupper() >>> after the fact as I did. >>> >>> Anyway maybe I should add a test for that corne

Re: [PATCH v3] wildmatch: properly fold case everywhere

2013-05-29 Thread Anthony Ramine
Replied inline. -- Anthony Ramine Le 29 mai 2013 à 15:52, Duy Nguyen a écrit : > On Wed, May 29, 2013 at 8:37 PM, Anthony Ramine wrote: >> Le 29 mai 2013 à 15:22, Duy Nguyen a écrit : >> >>> On Tue, May 28, 2013 at 8:58 PM, Anthony Ramine wrote: Case folding is not done correctly when m

Re: [PATCH v3] wildmatch: properly fold case everywhere

2013-05-29 Thread Duy Nguyen
On Wed, May 29, 2013 at 8:37 PM, Anthony Ramine wrote: > Le 29 mai 2013 à 15:22, Duy Nguyen a écrit : > >> On Tue, May 28, 2013 at 8:58 PM, Anthony Ramine wrote: >>> Case folding is not done correctly when matching against the [:upper:] >>> character class and uppercased character ranges (e.g. A-

Re: [PATCH v3] wildmatch: properly fold case everywhere

2013-05-29 Thread Anthony Ramine
Replied inline. Regards, -- Anthony Ramine Le 29 mai 2013 à 15:22, Duy Nguyen a écrit : > On Tue, May 28, 2013 at 8:58 PM, Anthony Ramine wrote: >> Case folding is not done correctly when matching against the [:upper:] >> character class and uppercased character ranges (e.g. A-Z). >> Specific

Re: [PATCH v3] wildmatch: properly fold case everywhere

2013-05-29 Thread Duy Nguyen
On Tue, May 28, 2013 at 8:58 PM, Anthony Ramine wrote: > Case folding is not done correctly when matching against the [:upper:] > character class and uppercased character ranges (e.g. A-Z). > Specifically, an uppercase letter fails to match against any of them > when case folding is requested beca

[PATCH v3] wildmatch: properly fold case everywhere

2013-05-28 Thread Anthony Ramine
Case folding is not done correctly when matching against the [:upper:] character class and uppercased character ranges (e.g. A-Z). Specifically, an uppercase letter fails to match against any of them when case folding is requested because plain characters in the pattern and the whole string and pre