Re: [PATCH v3 0/2] bringing attributes to pathspecs

2017-03-21 Thread Brandon Williams
On 03/21, Duy Nguyen wrote: > On Tue, Mar 14, 2017 at 1:23 AM, Brandon Williams wrote: > > v3 fixes some nits in style in the test script (using <<-\EOF instead of > > <<-EOF) > > as well as fixing a few other minor things reported by Junio and Jonathan. > > I'm slowly digging through the pile o

Re: [PATCH v3 0/2] bringing attributes to pathspecs

2017-03-21 Thread Junio C Hamano
Duy Nguyen writes: > The series updated match_pathspec(), but that's only one of two > pathspec filtering functions. The other is tree_entry_interesting() > (e.g. for "git grep "). Do you have plans to support :(attr) > there too? "No" is a perfectly fine answer (and it will end up in my > foreve

Re: [PATCH v3 0/2] bringing attributes to pathspecs

2017-03-21 Thread Duy Nguyen
On Tue, Mar 14, 2017 at 1:23 AM, Brandon Williams wrote: > v3 fixes some nits in style in the test script (using <<-\EOF instead of > <<-EOF) > as well as fixing a few other minor things reported by Junio and Jonathan. I'm slowly digging through the pile of mails in the past weeks... I know this

Re: [PATCH v3 0/2] bringing attributes to pathspecs

2017-03-13 Thread Brandon Williams
On 03/13, Junio C Hamano wrote: > Brandon Williams writes: > > > v3 fixes some nits in style in the test script (using <<-\EOF instead of > > <<-EOF) > > as well as fixing a few other minor things reported by Junio and Jonathan. > > Thanks. Will replace. > > I think this is ready for 'next',

Re: [PATCH v3 0/2] bringing attributes to pathspecs

2017-03-13 Thread Junio C Hamano
Brandon Williams writes: > v3 fixes some nits in style in the test script (using <<-\EOF instead of > <<-EOF) > as well as fixing a few other minor things reported by Junio and Jonathan. Thanks. Will replace. I think this is ready for 'next', so let's ask reviewers to really pay attention to

[PATCH v3 0/2] bringing attributes to pathspecs

2017-03-13 Thread Brandon Williams
v3 fixes some nits in style in the test script (using <<-\EOF instead of <<-EOF) as well as fixing a few other minor things reported by Junio and Jonathan. Brandon Williams (2): pathspec: allow querying for attributes pathspec: allow escaped query values Documentation/glossary-content.txt |