Re: [PATCH v3 01/10] submodule--helper: add is_active command

2017-03-14 Thread Brandon Williams
On 03/14, Junio C Hamano wrote: > Here is my attempt to rewrite the whole thing. > > The definition of which submodules are of interest by the user > is tied to the configuration submodule..url; when it is > set to a non-empty string, it is of interest. We'd want to be > able to

Re: [PATCH v3 01/10] submodule--helper: add is_active command

2017-03-14 Thread Junio C Hamano
Brandon Williams writes: > There are a lot of places where an explicit check for > submodule."".url is done to see if a submodule exists. In order > to centralize this check introduce a helper which can be used to query > if a submodule is active or not. "Right now,

Re: [PATCH v3 01/10] submodule--helper: add is_active command

2017-03-13 Thread Stefan Beller
On Mon, Mar 13, 2017 at 2:43 PM, Brandon Williams wrote: > There are a lot of places where an explicit check for > submodule."".url is done to see if a submodule exists. In order > to centralize this check introduce a helper which can be used to query > if a submodule is

[PATCH v3 01/10] submodule--helper: add is_active command

2017-03-13 Thread Brandon Williams
There are a lot of places where an explicit check for submodule."".url is done to see if a submodule exists. In order to centralize this check introduce a helper which can be used to query if a submodule is active or not. Signed-off-by: Brandon Williams ---