Re: [PATCH v3 04/10] daemon: recognize hidden request arguments

2017-10-13 Thread Brandon Williams
On 10/10, Jonathan Tan wrote: > On Tue, 3 Oct 2017 13:15:01 -0700 > Brandon Williams wrote: > > > /* > > * Read the host as supplied by the client connection. > > The return value is probably worth documenting. Something like "Returns > a pointer to the character *after*

Re: [PATCH v3 04/10] daemon: recognize hidden request arguments

2017-10-10 Thread Jonathan Tan
On Tue, 3 Oct 2017 13:15:01 -0700 Brandon Williams wrote: > /* > * Read the host as supplied by the client connection. The return value is probably worth documenting. Something like "Returns a pointer to the character *after* the NUL byte terminating the host argument, or

[PATCH v3 04/10] daemon: recognize hidden request arguments

2017-10-03 Thread Brandon Williams
A normal request to git-daemon is structured as "command path/to/repo\0host=..\0" and due to a bug introduced in 49ba83fb6 (Add virtualization support to git-daemon, 2006-09-19) we aren't able to place any extra arguments (separated by NULs) besides the host otherwise the parsing of those