Re: [PATCH v3 06/10] submodule update: add `--init-active` switch

2017-03-15 Thread Brandon Williams
On 03/14, Junio C Hamano wrote: > Brandon Williams writes: > > > +--init-active:: > > + This option is only valid for the update command. > > + Initialize all submodules configured in "`submodule.active`" > > + that have not been updated before. > > You mean s/not been

Re: [PATCH v3 06/10] submodule update: add `--init-active` switch

2017-03-15 Thread Brandon Williams
On 03/14, Junio C Hamano wrote: > Brandon Williams writes: > > > +static void module_list_active(struct module_list *list) > > +{ > > + int i; > > + > > + if (read_cache() < 0) > > + die(_("index file corrupt")); > > + > > + gitmodules_config(); > > + > > +

Re: [PATCH v3 06/10] submodule update: add `--init-active` switch

2017-03-14 Thread Junio C Hamano
Brandon Williams writes: > +static void module_list_active(struct module_list *list) > +{ > + int i; > + > + if (read_cache() < 0) > + die(_("index file corrupt")); > + > + gitmodules_config(); > + > + for (i = 0; i < active_nr; i++) { > +

Re: [PATCH v3 06/10] submodule update: add `--init-active` switch

2017-03-14 Thread Junio C Hamano
Brandon Williams writes: > +--init-active:: > + This option is only valid for the update command. > + Initialize all submodules configured in "`submodule.active`" > + that have not been updated before. You mean s/not been updated/not been initialized/ here? >

[PATCH v3 06/10] submodule update: add `--init-active` switch

2017-03-13 Thread Brandon Williams
The new switch `--init-active` initializes the submodules which are configured in `submodule.active` and `submodule..active` instead of those given as command line arguments before updating. In the first implementation this is made incompatible with further command line arguments as it is unclear