Re: [PATCH v3 1/1] clone: report duplicate entries on case-insensitive filesystems

2018-08-13 Thread Duy Nguyen
On Mon, Aug 13, 2018 at 6:55 PM Junio C Hamano wrote: > > Duy Nguyen writes: > > > I was careless and checked the wrong variable (should have checked > > nr_duplicates not state.nr_duplicates; the second is a pointer). So we > > always get this warning (and with no following list of files) > >

Re: [PATCH v3 1/1] clone: report duplicate entries on case-insensitive filesystems

2018-08-13 Thread Junio C Hamano
Duy Nguyen writes: > I was careless and checked the wrong variable (should have checked > nr_duplicates not state.nr_duplicates; the second is a pointer). So we > always get this warning (and with no following list of files) Heh, does that bug go away if you got rid of the pointer-ness of the

Re: [PATCH v3 1/1] clone: report duplicate entries on case-insensitive filesystems

2018-08-11 Thread Duy Nguyen
On Sat, Aug 11, 2018 at 12:09 PM SZEDER Gábor wrote: > > > > Paths that only differ in case work fine in a case-sensitive > > filesystems, but if those repos are cloned in a case-insensitive one, > > you'll get problems. The first thing to notice is "git status" will > > never be clean with no

Re: [PATCH v3 1/1] clone: report duplicate entries on case-insensitive filesystems

2018-08-11 Thread SZEDER Gábor
> Paths that only differ in case work fine in a case-sensitive > filesystems, but if those repos are cloned in a case-insensitive one, > you'll get problems. The first thing to notice is "git status" will > never be clean with no indication what exactly is "dirty". > > This patch helps the

Re: [PATCH v3 1/1] clone: report duplicate entries on case-insensitive filesystems

2018-08-10 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > +static void mark_duplicate_entries(const struct checkout *state, > +struct cache_entry *ce, struct stat *st) > +{ > + int i; > + int *count = state->nr_duplicates; > + > + if (!count) > +

[PATCH v3 1/1] clone: report duplicate entries on case-insensitive filesystems

2018-08-10 Thread Nguyễn Thái Ngọc Duy
Paths that only differ in case work fine in a case-sensitive filesystems, but if those repos are cloned in a case-insensitive one, you'll get problems. The first thing to notice is "git status" will never be clean with no indication what exactly is "dirty". This patch helps the situation a bit by