Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-11-19 Thread SZEDER Gábor
Ping? We are at -rc0, this progress output is a new feature since v2.19.0, and the numbers shown are still way off. On Mon, Oct 15, 2018 at 06:54:47PM +0200, SZEDER Gábor wrote: > On Mon, Sep 17, 2018 at 03:33:35PM +, Ævar Arnfjörð Bjarmason wrote: > > > @@ -560,6 +563,9 @@ static int add_p

Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-10-15 Thread SZEDER Gábor
On Mon, Sep 17, 2018 at 03:33:35PM +, Ævar Arnfjörð Bjarmason wrote: > @@ -560,6 +563,9 @@ static int add_packed_commits(const struct object_id *oid, > off_t offset = nth_packed_object_offset(pack, pos); > struct object_info oi = OBJECT_INFO_INIT; > > + if (list->progress) >

Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-10-15 Thread SZEDER Gábor
On Thu, Oct 11, 2018 at 07:52:21PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Oct 10 2018, Ævar Arnfjörð Bjarmason wrote: > > > On Wed, Oct 10 2018, SZEDER Gábor wrote: > > > >> On Wed, Oct 10, 2018 at 11:56:45PM +0200, Ævar Arnfjörð Bjarmason wrote: > >>> On Wed, Oct 10 2018, SZEDER Gábor

Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-10-12 Thread Derrick Stolee
On 10/12/2018 11:07 AM, Ævar Arnfjörð Bjarmason wrote: On Fri, Oct 12 2018, Junio C Hamano wrote: Makes sense. If this second iteration were also time consuming, then it probably is a good idea to split these into two separate phases? "Counting 1...N" followed by "Inspecting 1...N" or somethin

Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-10-12 Thread Ævar Arnfjörð Bjarmason
On Fri, Oct 12 2018, Junio C Hamano wrote: > SZEDER Gábor writes: > >>> for (i = 0; i < oids->nr; i++) { >>> + display_progress(progress, ++j); >>> commit = lookup_commit(the_repository, &oids->list[i]); >>> >>> if (commit && !parse_commit(commit)) >>> @@ -

Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-10-11 Thread Junio C Hamano
SZEDER Gábor writes: >> for (i = 0; i < oids->nr; i++) { >> +display_progress(progress, ++j); >> commit = lookup_commit(the_repository, &oids->list[i]); >> >> if (commit && !parse_commit(commit)) >> @@ -611,19 +624,28 @@ static void close_reachable(str

Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-10-11 Thread Ævar Arnfjörð Bjarmason
On Wed, Oct 10 2018, Ævar Arnfjörð Bjarmason wrote: > On Wed, Oct 10 2018, SZEDER Gábor wrote: > >> On Wed, Oct 10, 2018 at 11:56:45PM +0200, Ævar Arnfjörð Bjarmason wrote: >>> On Wed, Oct 10 2018, SZEDER Gábor wrote: >> >>> >> for (i = 0; i < oids->nr; i++) { >>> >> +di

Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-10-10 Thread Ævar Arnfjörð Bjarmason
On Wed, Oct 10 2018, SZEDER Gábor wrote: > On Wed, Oct 10, 2018 at 11:56:45PM +0200, Ævar Arnfjörð Bjarmason wrote: >> On Wed, Oct 10 2018, SZEDER Gábor wrote: > >> >> for (i = 0; i < oids->nr; i++) { >> >> + display_progress(progress, ++j); >> >> [...] >> >> > This display_progress()

Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-10-10 Thread SZEDER Gábor
On Wed, Oct 10, 2018 at 11:56:45PM +0200, Ævar Arnfjörð Bjarmason wrote: > On Wed, Oct 10 2018, SZEDER Gábor wrote: > >>for (i = 0; i < oids->nr; i++) { > >> + display_progress(progress, ++j); > > [...] > > > This display_progress() call, however, doesn't seem to be necessary. > > F

Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-10-10 Thread Ævar Arnfjörð Bjarmason
On Wed, Oct 10 2018, SZEDER Gábor wrote: > On Mon, Sep 17, 2018 at 03:33:35PM +, Ævar Arnfjörð Bjarmason wrote: >> $ git -c gc.writeCommitGraph=true gc >> [...] >> Annotating commits in commit graph: 1565573, done. >> Computing commit graph generation numbers: 100% (782484/78

Re: [PATCH v3 1/2] commit-graph write: add progress output

2018-10-10 Thread SZEDER Gábor
On Mon, Sep 17, 2018 at 03:33:35PM +, Ævar Arnfjörð Bjarmason wrote: > $ git -c gc.writeCommitGraph=true gc > [...] > Annotating commits in commit graph: 1565573, done. > Computing commit graph generation numbers: 100% (782484/782484), done. While poking around 'commit-graph.c'

[PATCH v3 1/2] commit-graph write: add progress output

2018-09-17 Thread Ævar Arnfjörð Bjarmason
Before this change the "commit-graph write" command didn't report any progress. On my machine this command takes more than 10 seconds to write the graph for linux.git, and around 1m30s on the 2015-04-03-1M-git.git[1] test repository (a test case for a large monorepository). Furthermore, since the