[PATCH v3 1/2] rev-parse tests: add tests executed from a subdirectory

2017-02-17 Thread Johannes Schindelin
From: Michael Rappazzo t2027-worktree-list has an incorrect expectation for --git-common-dir which has been adjusted and marked to expect failure. Some of the tests added have been marked to expect failure. These demonstrate a problem with the way that some options to git

Re: [PATCH v3 1/2] rev-parse tests: add tests executed from a subdirectory

2016-05-08 Thread Junio C Hamano
Junio C Hamano writes: > What I had in mind was more a long the lines of this change. I only > did the first several just for illustration (I added an 'exit' to > mark where I stopped), but I think you get the idea. The point is > that by doing things in subprocess inside

Re: [PATCH v3 1/2] rev-parse tests: add tests executed from a subdirectory

2016-05-08 Thread Junio C Hamano
Mike Rappazzo writes: >> Instead of cleaning things up like this, could you please please >> please fix these existing tests that chdir around without being in a >> subshell? If the "previous tests" failed before going down as this >> step expects, the "cd .. && rm -r" can

Re: [PATCH v3 1/2] rev-parse tests: add tests executed from a subdirectory

2016-05-07 Thread Mike Rappazzo
On Fri, May 6, 2016 at 6:10 PM, Junio C Hamano wrote: > Michael Rappazzo writes: > >> t1500-rev-parse contains envrionment leaks (changing dir without >> changing back, setting config variables, etc). Add a test to clean this >> up up so that future tests

Re: [PATCH v3 1/2] rev-parse tests: add tests executed from a subdirectory

2016-05-06 Thread Junio C Hamano
Michael Rappazzo writes: > t1500-rev-parse contains envrionment leaks (changing dir without > changing back, setting config variables, etc). Add a test to clean this > up up so that future tests can be added without worry of any setting > from a previous test. This is a

[PATCH v3 1/2] rev-parse tests: add tests executed from a subdirectory

2016-05-06 Thread Michael Rappazzo
t1500-rev-parse contains envrionment leaks (changing dir without changing back, setting config variables, etc). Add a test to clean this up up so that future tests can be added without worry of any setting from a previous test. t2027-worktree-list has an incorrect expectation for