Re: [PATCH v3 1/3] patch-id: make it stable against hunk reordering

2014-03-31 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > + memcpy(&ctx, &header_ctx, > sizeof ctx); > + } else { > + /* Save header ctx for next > hunk. */ > +

Re: [PATCH v3 1/3] patch-id: make it stable against hunk reordering

2014-03-31 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > though it does look like an unrelated enhancement to me. > Agree? Yes, that is exactly why I said "opens interesting opportunity" and "making it possible" ;-) They are all very related, but they do not have to graduate as parts of the same series. The important th

Re: [PATCH v3 1/3] patch-id: make it stable against hunk reordering

2014-03-31 Thread Michael S. Tsirkin
On Mon, Mar 31, 2014 at 10:59:50AM -0700, Junio C Hamano wrote: > "Michael S. Tsirkin" writes: > > > Patch id changes if users > > 1. reorder file diffs that make up a patch > > or > > 2. split a patch up to multiple diffs that touch the same path > > (keeping hunks within a single diff ordered t

Re: [PATCH v3 1/3] patch-id: make it stable against hunk reordering

2014-03-31 Thread Junio C Hamano
"Michael S. Tsirkin" writes: > Patch id changes if users > 1. reorder file diffs that make up a patch > or > 2. split a patch up to multiple diffs that touch the same path > (keeping hunks within a single diff ordered to make patch valid). > > As the result is functionally equivalent, a different

[PATCH v3 1/3] patch-id: make it stable against hunk reordering

2014-03-30 Thread Michael S. Tsirkin
Patch id changes if users 1. reorder file diffs that make up a patch or 2. split a patch up to multiple diffs that touch the same path (keeping hunks within a single diff ordered to make patch valid). As the result is functionally equivalent, a different patch id is surprising to many users. In pa