Re: [PATCH v3 1/4] stash: add test for stash create with no files

2017-05-29 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> + git stash create > actual && >> + test $(cat actual | wc -l) -eq 0 > ... > Although I wonder in this case whether you don't actually mean: > > [...]>actual && > ! test -s actual > > I.e. isn't the test that there should

Re: [PATCH v3 1/4] stash: add test for stash create with no files

2017-05-28 Thread Ævar Arnfjörð Bjarmason
On Sun, May 28, 2017 at 6:56 PM, Joel Teichroeb wrote: > Ensure the command gives the correct return code > > Signed-off-by: Joel Teichroeb > --- > t/t3903-stash.sh | 8 > 1 file changed, 8 insertions(+) > > diff --git a/t/t3903-stash.sh

[PATCH v3 1/4] stash: add test for stash create with no files

2017-05-28 Thread Joel Teichroeb
Ensure the command gives the correct return code Signed-off-by: Joel Teichroeb --- t/t3903-stash.sh | 8 1 file changed, 8 insertions(+) diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh index 3b4bed5c9a..aaae221304 100755 --- a/t/t3903-stash.sh +++