Re: [PATCH v3 1/4] transport: drop refnames from for_each_alternate_ref

2018-09-28 Thread Taylor Blau
On Fri, Sep 28, 2018 at 12:58:58AM -0400, Jeff King wrote: > > From: Jeff King > > Pretty sure that isn't right. :) Indeed that isn't right :-). I try my best to review my patches diligently before submitting them, but here's an interesting side-story if you're interested: I use a script 'git

Re: [PATCH v3 1/4] transport: drop refnames from for_each_alternate_ref

2018-09-27 Thread Jeff King
> From: Jeff King Pretty sure that isn't right. :) The preferred way to send a patch with a different author is to have actual email be "From:" you, but then include a: From: Jeff King as the first line of the body (which git-am will then pick up). git-send-email will do this for you

[PATCH v3 1/4] transport: drop refnames from for_each_alternate_ref

2018-09-27 Thread Jeff King
None of the current callers use the refname parameter we pass to their callbacks. In theory somebody _could_ do so, but it's actually quite weird if you think about it: it's a ref in somebody else's repository. So the name has no meaning locally, and in fact there may be duplicates if there are