On Thu, Sep 27, 2018 at 2:18 PM SZEDER Gábor wrote:
>
> On Tue, Sep 25, 2018 at 02:58:08PM -0700, Matthew DeVore wrote:
> > + - Use Git upstream in the non-final position in a piped chain, as in:
>
> Note the starting upper case 'U'.
>
> > + - Use command substitution in a way that discards git's
On Tue, Sep 25, 2018 at 02:58:08PM -0700, Matthew DeVore wrote:
> Here is the new commit with updated message (I will wait for a day or
> two before I send a reroll):
>
> Documentation: add shell guidelines
>
> Add the following guideline to Documentation/CodingGuidelines:
>
>
On Mon, Sep 24, 2018 at 2:03 PM SZEDER Gábor wrote:
> > + - In a piped chain such as "grep blob objects | sort", the exit codes
>
> Let's make an example with git in it, e.g. something like this:
>
> git cmd | grep important | sort
>
> since just two lines below the new text mentions git
On Thu, Sep 20, 2018 at 06:43:27PM -0700, Matthew DeVore wrote:
> Add two guidelines:
>
> - pipe characters should appear at the end of lines, and not cause
>indentation
> - pipes should be avoided when they swallow exit codes that can
>potentially fail
> ---
>
On Thu, Sep 20, 2018 at 7:06 PM Eric Sunshine wrote:
>
> On Thu, Sep 20, 2018 at 9:43 PM Matthew DeVore wrote:
> > Add two guidelines:
>
> Probably s/two/three/ or s/two/several/ since the patch now adds three
> guidelines.
>
> > - pipe characters should appear at the end of lines, and not
On Thu, Sep 20, 2018 at 9:43 PM Matthew DeVore wrote:
> Add two guidelines:
Probably s/two/three/ or s/two/several/ since the patch now adds three
guidelines.
> - pipe characters should appear at the end of lines, and not cause
>indentation
The "not cause indentation" bit is outdated
Add two guidelines:
- pipe characters should appear at the end of lines, and not cause
indentation
- pipes should be avoided when they swallow exit codes that can
potentially fail
---
Documentation/CodingGuidelines | 27 +++
1 file changed, 27 insertions(+)
diff
7 matches
Mail list logo
