Re: [PATCH v3 1/9] am: stop ignoring errors reported by log_tree_diff()

2016-06-22 Thread Johannes Schindelin
Hi Junio, On Tue, 21 Jun 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Note: there are more places in the builtin am code that ignore > > errors returned from library functions. Fixing those is outside the > > purview of the current patch series, though. > > The caller of par

Re: [PATCH v3 1/9] am: stop ignoring errors reported by log_tree_diff()

2016-06-21 Thread Junio C Hamano
Johannes Schindelin writes: > Note: there are more places in the builtin am code that ignore > errors returned from library functions. Fixing those is outside the > purview of the current patch series, though. The caller of parse_mail() and parse_mail_rebase() is not prepared to see an error cod

[PATCH v3 1/9] am: stop ignoring errors reported by log_tree_diff()

2016-06-21 Thread Johannes Schindelin
It is never a good idea to ignore errors, so let's handle them. While at it, handle fopen() errors more gently (i.e. give the caller a chance to do something about it rather than die()ing). Note: there are more places in the builtin am code that ignore errors returned from library functions. Fixi