Re: [PATCH v3 2/2] Windows: do not treat a path with backslashes as a remote's nick name

2017-05-25 Thread Junio C Hamano
Johannes Sixt writes: >>> So in short: >>> >>> (1) Hannes's patches are good, but they solve a problem that is >>> different from what their log messages say; the log message >>> needs to be updated; > > I do not resend patch 1/2 as it is unchanged in all regards.

[PATCH v3 2/2] Windows: do not treat a path with backslashes as a remote's nick name

2017-05-25 Thread Johannes Sixt
On Windows, the remote repository name in, e.g., `git fetch foo\bar` is clearly not a nickname for a configured remote repository. However, the function valid_remote_nick() does not account for backslashes. Use is_dir_sep() to check for both slashes and backslashes on Windows. This was discovered