Re: [PATCH v3 2/2] strbuf: change an always NULL/"" strbuf_addftime() param to bool

2017-06-24 Thread Jeff King
On Sat, Jun 24, 2017 at 11:36:35AM +, Ævar Arnfjörð Bjarmason wrote: > >> extern void strbuf_addftime(struct strbuf *sb, const char *fmt, > >>const struct tm *tm, int tz_offset, > >> - const char *tz_name); > >> + const int

[PATCH v3 2/2] strbuf: change an always NULL/"" strbuf_addftime() param to bool

2017-06-24 Thread Ævar Arnfjörð Bjarmason
Change the code for deciding what's to be done about %Z to stop passing always either a NULL or "" char * to strbuf_addftime(). Instead pass a boolean int to indicate whether the strftime() %Z format should be suppressed by converting it to an empty string, which is what this code is actually