Re: [PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags

2016-04-04 Thread Jeff King
On Sun, Apr 03, 2016 at 09:38:34PM -0400, Eric Sunshine wrote: > I think Peff meant that a simple grep would suffice; no need for > test_i18ngrep. In other words (reproducing Peff's example), something > like this: > > tags="fourth-signed sixth-signed seventh-signed" && > for i in $tags;

Re: [PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags

2016-04-03 Thread Eric Sunshine
On Sun, Apr 3, 2016 at 5:58 PM, Santiago Torres wrote: > On Sun, Apr 03, 2016 at 09:07:25AM -0400, Jeff King wrote: >> On Sun, Apr 03, 2016 at 03:59:46AM -0400, Eric Sunshine wrote: >> > On Sun, Apr 3, 2016 at 12:40 AM, Jeff King wrote: >> > > In fact, I suspect

Re: [PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags

2016-04-03 Thread Santiago Torres
On Sun, Apr 03, 2016 at 09:07:25AM -0400, Jeff King wrote: > On Sun, Apr 03, 2016 at 03:59:46AM -0400, Eric Sunshine wrote: > > > On Sun, Apr 3, 2016 at 12:40 AM, Jeff King wrote: > > > In fact, I suspect you could replace the "GOODSIG" check as well by > > > doing something like:

Re: [PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags

2016-04-03 Thread Jeff King
On Sun, Apr 03, 2016 at 03:59:46AM -0400, Eric Sunshine wrote: > On Sun, Apr 3, 2016 at 12:40 AM, Jeff King wrote: > > In fact, I suspect you could replace the "GOODSIG" check as well by > > doing something like: > > > > # verifying 3 tags in one invocation should be exactly

Re: [PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags

2016-04-03 Thread Eric Sunshine
On Sun, Apr 3, 2016 at 12:40 AM, Jeff King wrote: > In fact, I suspect you could replace the "GOODSIG" check as well by > doing something like: > > # verifying 3 tags in one invocation should be exactly like > # verifying the 3 separately > tags="fourth-signed sixth-signed

Re: [PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags

2016-04-02 Thread Jeff King
On Sat, Apr 02, 2016 at 07:16:13PM -0400, santi...@nyu.edu wrote: > The verify-tag command supports mutliple tag names as an argument. s/mutliple/multiple/ > +test_expect_success GPG 'verify multiple tags' ' > + git verify-tag -v --raw fourth-signed sixth-signed seventh-signed > 2>actual

[PATCH v3 2/4] t/t7030-verify-tag.sh: Adds validation for multiple tags

2016-04-02 Thread santiago
From: Santiago Torres The verify-tag command supports mutliple tag names as an argument. However, no previous tests try to verify multiple tags at once. This test runs the verify-tag command against three trusted tags (created previously), and ensures that: 1) Three