Re: [PATCH v3 3/3] config: add '--show-origin' option to print the origin of a config value

2016-02-15 Thread Lars Schneider
On 13 Feb 2016, at 19:15, Jeff King wrote: > On Sat, Feb 13, 2016 at 01:04:12PM -0500, Jeff King wrote: > >> On Sat, Feb 13, 2016 at 12:44:49PM -0500, Jeff King wrote: >> +test_expect_success '--show-origin' ' >>> [...] >>> I see you split this up more, but there's still

Re: [PATCH v3 3/3] config: add '--show-origin' option to print the origin of a config value

2016-02-14 Thread Johannes Schindelin
Hi Peff, tl;dr let's keep an eye on adding only test cases that do not depend on earlier test cases' output ('setup' excluded, of course). On Sun, 14 Feb 2016, Jeff King wrote: > In general, my opinion is that skipping arbitrary leading tests is a > losing strategy. It's just too easy to

Re: [PATCH v3 3/3] config: add '--show-origin' option to print the origin of a config value

2016-02-14 Thread Lars Schneider
On 13 Feb 2016, at 18:44, Jeff King wrote: > On Sat, Feb 13, 2016 at 03:24:16PM +0100, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider >> >> If config values are queried using 'git config' (e.g. via --get, >> --get-all, --get-regexp, or

Re: [PATCH v3 3/3] config: add '--show-origin' option to print the origin of a config value

2016-02-14 Thread Jeff King
On Sun, Feb 14, 2016 at 01:48:59PM +0100, Lars Schneider wrote: > > I see you split this up more, but there's still quite a bit going on in > > this one block. IMHO, it would be more customary in our tests to put the > > setup into one test_expect_success block, then each of these > >

[PATCH v3 3/3] config: add '--show-origin' option to print the origin of a config value

2016-02-13 Thread larsxschneider
From: Lars Schneider If config values are queried using 'git config' (e.g. via --get, --get-all, --get-regexp, or --list flag) then it is sometimes hard to find the configuration file where the values were defined. Teach 'git config' the '--show-origin' option to print

Re: [PATCH v3 3/3] config: add '--show-origin' option to print the origin of a config value

2016-02-13 Thread Jeff King
On Sat, Feb 13, 2016 at 03:24:16PM +0100, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > If config values are queried using 'git config' (e.g. via --get, > --get-all, --get-regexp, or --list flag) then it is sometimes hard to > find the configuration file

Re: [PATCH v3 3/3] config: add '--show-origin' option to print the origin of a config value

2016-02-13 Thread Jeff King
On Sat, Feb 13, 2016 at 12:44:49PM -0500, Jeff King wrote: > > +test_expect_success '--show-origin' ' > [...] > I see you split this up more, but there's still quite a bit going on in > this one block. IMHO, it would be more customary in our tests to put the > setup into one test_expect_success

Re: [PATCH v3 3/3] config: add '--show-origin' option to print the origin of a config value

2016-02-13 Thread Jeff King
On Sat, Feb 13, 2016 at 01:04:12PM -0500, Jeff King wrote: > On Sat, Feb 13, 2016 at 12:44:49PM -0500, Jeff King wrote: > > > > +test_expect_success '--show-origin' ' > > [...] > > I see you split this up more, but there's still quite a bit going on in > > this one block. IMHO, it would be more