[PATCH v3 3/6] imap-send.c: replace `git_config()` with `git_config_get_*()` family

2014-07-21 Thread Tanay Abhra
Use `git_config_get_*()` family instead of `git_config()` to take advantage of the config-set API which provides a cleaner control flow. The function now raises an error instead of dying in cases where a NULL value is not allowed. Signed-off-by: Tanay Abhra tanay...@gmail.com --- imap-send.c |

Re: [PATCH v3 3/6] imap-send.c: replace `git_config()` with `git_config_get_*()` family

2014-07-21 Thread Junio C Hamano
Tanay Abhra tanay...@gmail.com writes: + git_config_get_string(imap.folder, (const char**)imap_folder); The same why (const char **)--is that an API mistake? question applies here and other calls to git_config_get_string() in this patch. -- To unsubscribe from this list: send the line